rionmonster commented on PR #27598: URL: https://github.com/apache/flink/pull/27598#issuecomment-3893405976
@DeamonDev > I wonder on whether I should set this very new flag when spawning `CommitableCollector` in `CommitableCollectionSerializer#deserializeV2`. ATM I've set it to false but I am not quite sure. WDYT? Yes, I think using `false` would be correct in this case. A cursory trace through `deserializeV2()` seems to validate that as these deserialized instances are transient and eventually merged into the live collector: - `deserializeV2` creates a _new_ `CommitableCollector` instance from the checkpoint - This new instance gets returned to the original iterator in `CommitterOperator#initializeState` and merged into the existing _live_ instance of the collector (copying its data via a merge) So we don't want to re-reregister the metrics during those transient instances that eventually are just discarded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
