DeamonDev commented on code in PR #27598:
URL: https://github.com/apache/flink/pull/27598#discussion_r2803198827
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollector.java:
##########
Review Comment:
Ok, now the constructor is
```java
public CommittableCollector(
SinkCommitterMetricGroup metricGroup, boolean
shouldSetPendingCommittablesGauge) {
this(new TreeMap<>(), metricGroup, shouldSetPendingCommittablesGauge);
}
```
and I adjusted it only in `ofLegacy` method where I think it should be set
to `false`. Still I'm not quite sure if thats correct. So, I have another
request for advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
