xintongsong commented on code in PR #532: URL: https://github.com/apache/flink-agents/pull/532#discussion_r2844876213
########## integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPTool.java: ########## @@ -38,6 +39,7 @@ * <p>This represents a single tool from an MCP server. It extends the base Tool class and delegates * actual execution to the MCP server. */ +@JsonIgnoreProperties(ignoreUnknown = true) Review Comment: Call me old-fashioned, but I'd suggest to explicitly list the properties to be ignored rather than just ignore everything unknown. This forces us to explicitly think about whether a field should be ignored when adding a new one (or the test case will fail), preventing accidentally adding a new field without updating the serde. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
