avichaym commented on code in PR #532:
URL: https://github.com/apache/flink-agents/pull/532#discussion_r2871976579
##########
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPTool.java:
##########
@@ -38,6 +39,7 @@
* <p>This represents a single tool from an MCP server. It extends the base
Tool class and delegates
* actual execution to the MCP server.
*/
+@JsonIgnoreProperties(ignoreUnknown = true)
Review Comment:
Thanks for the feedback. I've adopted wenjin272's approach — added
@JsonIgnore on Tool.getName(), Tool.getDescription(), and
Tool.getResourceType() so these redundant fields
are never serialized in the first place. This removes the need for
@JsonIgnoreProperties on MCPTool entirely.
The fix is in Tool.java (api module) rather than MCPTool.java, so it
benefits all Tool subclasses, not just MCPTool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
