gustavodemorais commented on code in PR #27777:
URL: https://github.com/apache/flink/pull/27777#discussion_r2959437856
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/ToChangelogFunction.java:
##########
@@ -108,18 +121,13 @@ public void eval(
final RowData input,
@Nullable final ColumnList op,
@Nullable final Map<String, String> opMapping) {
Review Comment:
Sorry, that makes sense. I was thinking about the values themselves
(constants vs changing data), but the conversion overhead comes from the
generated code, which doesn't distinguish between constant and per-row
arguments. It applies the same type conversion logic to every argument on every
invoke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
