raminqaf commented on code in PR #27807:
URL: https://github.com/apache/flink/pull/27807#discussion_r2973718534
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterTableChangeOperation.java:
##########
@@ -97,7 +97,9 @@ public static String toString(TableChange tableChange) {
return String.format(
" MODIFY %s COMMENT '%s'",
EncodingUtils.escapeIdentifier(modifyColumnComment.getNewColumn().getName()),
- modifyColumnComment.getNewComment());
+ modifyColumnComment.getNewComment() == null
+ ? ""
+ : modifyColumnComment.getNewComment());
Review Comment:
Shouldn't we avoid `MODIFY COMMENT` if the comment is null, instead of
returning:
```sql
MODIFY 'id' COMMENT ''
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
