raminqaf commented on code in PR #27807: URL: https://github.com/apache/flink/pull/27807#discussion_r2973732396
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlNodeToOperationSqlCreateOrAlterMaterializedTableConverterTest.java: ########## Review Comment: Thanks for the new test setup. I noticed that some cases are not tests: - Adding a constraint, for the case that `oldConstraint == null` - Unchanged table (zero chagnes) - It would be interesting to have a test that has a schema with only watermark/constraint, no regular columns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
