xuyangzhong commented on PR #27809: URL: https://github.com/apache/flink/pull/27809#issuecomment-4116761428
> @xuyangzhong Thanks for the pr! Overall looks good. I left some comments there. > > One question regarding the `SHOW CREATE TABLE` path: I understand this FLIP does not yet expose the constraint via DDL syntax, but if we silently omit the new constraint from the output, it could break DDL round-trip fidelity, WDYT? Currently, `asSummaryString` in `Constraint` only works for `toString`. The schema printing for "SHOW CREATE TABLE" is handled in a different place: `ShowCreateUtil.buildShowCreateTableRow`. Regardless, I will add a test in `ShowCreateUtilTest` to prevent the immutable columns constraint from being included in the `SHOW CREATE TABLE` output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
