lincoln-lil commented on PR #27809: URL: https://github.com/apache/flink/pull/27809#issuecomment-4118860309
> Hi, @lincoln-lil I have addressed all comments and added a new commit about https://issues.apache.org/jira/browse/FLINK-39314 in this pr. Can you please take a look again? I checked these changes, looks semantically correct and addresses a real non-opt issue where only the first upsert key was checked instead of all available upsert keys. The existing tests provide partial coverage, so additional tests for the multi-upsertkey scenario would be beneficial(not strictly required). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
