[
https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833953#comment-15833953
]
ASF GitHub Bot commented on FLINK-5508:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97253388
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -394,6 +395,14 @@ protected int runPrivileged(Configuration config,
Configuration dynamicPropertie
}
}
+ if (mesosServices != null) {
+ try {
+ mesosServices.close(false);
+ } catch (Throwable tt) {
+ LOG.error("Error closing the
ZooKeeperUtilityFactory.", tt);
--- End diff --
This error message is only relevant to `ZooKeeperMesosServices`, and not
`StandaloneMesosServices.`
Should we just use "Failed to clean up and close MesosServices." here, and
rely on the stack trace in logs to find out the case?
> Remove Mesos dynamic class loading
> ----------------------------------
>
> Key: FLINK-5508
> URL: https://issues.apache.org/jira/browse/FLINK-5508
> Project: Flink
> Issue Type: Improvement
> Components: Mesos
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.2.0, 1.3.0
>
>
> Mesos uses dynamic class loading in order to load the
> {{ZooKeeperStateHandleStore}} and the {{CuratorFramework}} class. This can be
> replaced by a compile time dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
