[ 
https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833948#comment-15833948
 ] 

ASF GitHub Bot commented on FLINK-5508:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3157#discussion_r97255571
  
    --- Diff: 
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManagerTest.java
 ---
    @@ -73,13 +74,16 @@
     /**
      * General tests for the Mesos resource manager component.
      */
    -public class MesosFlinkResourceManagerTest {
    +public class MesosFlinkResourceManagerTest extends TestLogger {
     
        private static final Logger LOG = 
LoggerFactory.getLogger(MesosFlinkResourceManagerTest.class);
     
        private static ActorSystem system;
     
    -   private static Configuration config = new Configuration() {{
    +   private static Configuration config = new Configuration() {
    +           private static final long serialVersionUID = 
-952579203067648838L;
    +
    +           {
    --- End diff --
    
    The indentation in this static block seems to be disordered (the following 
2 `setInteger`s should be indented with one more tab).


> Remove Mesos dynamic class loading
> ----------------------------------
>
>                 Key: FLINK-5508
>                 URL: https://issues.apache.org/jira/browse/FLINK-5508
>             Project: Flink
>          Issue Type: Improvement
>          Components: Mesos
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.2.0, 1.3.0
>
>
> Mesos uses dynamic class loading in order to load the 
> {{ZooKeeperStateHandleStore}} and the {{CuratorFramework}} class. This can be 
> replaced by a compile time dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to