rkhachatryan commented on PR #28107: URL: https://github.com/apache/flink/pull/28107#issuecomment-4389586519
One more thing: do we really need to expose `RecoveredBufferStoreImpl.getGateLock()`? It looks like most operations that use this lock are adding `buffer` to this store (so the sync can be internal in this class). And the rest can probably use loan pattern - if they need? (sorry, GH doesn't let me comment in-line due to internal error) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
