1996fanrui commented on code in PR #28107:
URL: https://github.com/apache/flink/pull/28107#discussion_r3235025994
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriter.java:
##########
@@ -204,6 +212,12 @@ public void addInputData(
int startSeqNum,
CloseableIterator<Buffer> data) {}
+ @Override
+ public void addInputDataFromSpill(
+ long checkpointId, CloseableIterator<FilteredSpillFile.Chunk>
chunks) {
+ IOUtils.closeQuietly(chunks);
+ }
+
Review Comment:
The existing `addInputData` only read data from `Buffer`, which has to load
data from disk to memory.
The new approach needs to snapshot data from disk, the new
`addInputDataFromSpill` is file-faced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
