Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3214471829
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -191,7 +206,7 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
public static final ConfigOption<Integer>
ASSUME_ROLE_SESSION_DURATION_SECONDS =
ConfigOptions.key("s3.assume-role.session-duration")
.intType()
- .defaultValue(3600) // 1 hour default
+ .defaultValue(3600)
Review Comment:
Correct — those were unrelated cosmetic cleanups that slipped in during the
initial draft. They have been reverted; the factory method now matches master
exactly except for the bucket-override application block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
