Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3214471662
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -31,16 +31,32 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import javax.annotation.Nullable;
+
import java.io.IOException;
import java.net.URI;
import java.time.Duration;
+import java.util.concurrent.TimeUnit;
/**
- * Factory for creating Native S3 FileSystem instances.
+ * Factory for creating Native S3 FileSystem instances using AWS SDK v2.
+ *
+ * <h3>Bucket-Level Configuration</h3>
*
- * <p>This factory creates {@link NativeS3FileSystem} instances for accessing
Amazon S3 buckets
- * using AWS SDK v2. The Native S3 FileSystem provides a drop-in replacement
for Presto and Hadoop
- * S3 implementations with minimal external dependencies.
+ * <p>Supports per-bucket configuration overrides using the format {@code
+ * s3.bucket.<bucket-name>.<property>}. Bucket-level settings override global
settings; unset
+ * properties inherit global values. Supported properties:
+ *
+ * <ul>
+ * <li>{@code region} - AWS region for this bucket
+ * <li>{@code endpoint} - custom S3 endpoint
+ * <li>{@code path-style-access} - use path-style S3 access
+ * <li>{@code access-key} / {@code secret-key} - bucket-specific credentials
+ * <li>{@code sse.type} / {@code sse.kms-key-id} - server-side encryption
+ * <li>{@code assume-role.arn} / {@code assume-role.external-id} / {@code
+ * assume-role.session-name} / {@code assume-role.session-duration} -
IAM assume role
+ * <li>{@code credentials.provider} - custom credentials provider class
+ * </ul>
Review Comment:
Agreed. The class Javadoc no longer duplicates a hardcoded list of config
keys. It now simply says "See `BucketConfigProvider#PROPERTY_APPLICATORS` for
the complete list of supported bucket-level properties." — so the authoritative
source of truth is the code itself, and the Javadoc will never go stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
