snuyanzin commented on code in PR #28152:
URL: https://github.com/apache/flink/pull/28152#discussion_r3235155095
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/SqlGroupedWindowFunction.java:
##########
@@ -26,9 +25,12 @@
import org.apache.calcite.sql.type.SqlReturnTypeInference;
import org.apache.calcite.sql.type.SqlTypeName;
import org.apache.calcite.sql.validate.SqlMonotonicity;
+import org.checkerframework.checker.nullness.qual.Nullable;
import java.util.List;
+import static com.google.common.base.Preconditions.checkArgument;
Review Comment:
Synced with Calcite
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/SqlIntervalQualifier.java:
##########
@@ -883,7 +883,7 @@ private int[] evaluateIntervalLiteralAsDayToSecond(
// Note: must check two patterns, since fractional second is optional
final int fractionalSecondPrecision =
getFractionalSecondPrecision(typeSystem);
String intervalPatternWithFracSec =
- "(\\d+) (\\d{1,2}):(\\d{1,2}):(\\d{1,2})\\.(\\d{1,"
+ "(\\d+) (\\d{1,2}):(\\d{1,2}):(\\d{1,2})\\.(\\d{0,"
Review Comment:
Synced with Calcite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]