snuyanzin commented on code in PR #28152:
URL: https://github.com/apache/flink/pull/28152#discussion_r3235179643


##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/FlinkPruneEmptyRulesTest.xml:
##########
@@ -152,7 +152,13 @@ LogicalMinus(all=[false])
     </Resource>
     <Resource name="optimized rel plan">
       <![CDATA[
-LogicalValues(tuples=[[]])
+LogicalMinus(all=[false])
+:- LogicalMinus(all=[false])
+:  :- LogicalValues(tuples=[[]])
+:  +- LogicalProject(EXPR$0=[20], EXPR$1=[2])
+:     +- LogicalValues(tuples=[[{ 20, 2 }]])
++- LogicalProject(EXPR$0=[40], EXPR$1=[4])
+   +- LogicalValues(tuples=[[{ 40, 4 }]])

Review Comment:
   this is the result of  https://issues.apache.org/jira/browse/CALCITE-6044 
optimization
   however such behavior is only for case of `VALUES`, so probably should be 
acceptable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to