wenjin272 commented on code in PR #678:
URL: https://github.com/apache/flink-agents/pull/678#discussion_r3246340994
##########
integrations/vector-stores/opensearch/src/main/java/org/apache/flink/agents/integrations/vectorstores/opensearch/OpenSearchVectorStore.java:
##########
@@ -400,7 +418,14 @@ public List<String> addEmbedding(
allIds.add(id);
Review Comment:
Since AOSS does not allow clients to specify IDs, returning this ID in the
AOSS scenario is meaningless, as users cannot use it for get or delete
operations. I believe that in the AOSS scenario, we should return the ID
generated by AOSS.
##########
integrations/vector-stores/opensearch/src/main/java/org/apache/flink/agents/integrations/vectorstores/opensearch/OpenSearchVectorStore.java:
##########
Review Comment:
Currently, updateEmbedding is implemented by inserting a document with the
same ID. In the AOSS scenario, since the client cannot specify an ID, this
approach fails to achieve the update purpose. Therefore, we should throw an
"unsupported operation" exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
