avichaym commented on code in PR #678:
URL: https://github.com/apache/flink-agents/pull/678#discussion_r3248695668
##########
integrations/vector-stores/opensearch/src/main/java/org/apache/flink/agents/integrations/vectorstores/opensearch/OpenSearchVectorStore.java:
##########
@@ -400,7 +418,14 @@ public List<String> addEmbedding(
allIds.add(id);
Review Comment:
Both points addressed. updateEmbedding on AOSS now throws
UnsupportedOperationException (with a message pointing to the provisioned
domain as an alternative), and add() on serverless parses items[].index._id out
of each _bulk response and returns those AOSS-generated ids instead of the
client-side UUIDs. Provisioned-domain behaviour is unchanged. Verified
end-to-end against the live AOSS test collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
