wenjin272 commented on PR #655:
URL: https://github.com/apache/flink-agents/pull/655#issuecomment-4488644387
Hi, @wzhero1, thanks for round three. All three taken:
- **Python base64 silently corrupting binary resources**: spot on —
f-string was inlining the bytes repr, not real base64. Switched to
`base64.b64encode(...).decode("ascii")`. The single-line
`startsWith("base64: ")` assertion is exactly how this hid for a cycle; both
Java and Python tests now b64-decode the
value and assert the round-trip against a PNG signature + non-UTF-8 byte
sequence. — e7956487
- **Python partial-load leak**: Python `_load_skills` now closes
already-opened repos before re-raising, mirroring the Java fix from round two.
— aa7c9785
- **Duplicate-name repo orphan in `close()`**: confirmed on both sides —
the skill-name → repo map drops the displaced repo's reference, so iterating it
on close orphaned the
earlier repo. Added an `openedRepos`/`_opened_repos` list (identity /
`id()` dedup) and changed close to iterate that. New test on each side: two
sources contributing the
same skill name, both repos must be closed. — 8b10d3ab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
