gaborgsomogyi commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3280297225
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/token/DynamicTemporaryAWSCredentialsProvider.java:
##########
@@ -37,9 +38,13 @@
* reference this class name from configuration property
fs.s3a.aws.credentials.provider. Therefore,
* changing the class name would be a backward-incompatible change. This
credential provider must
* not fail in creation because that will break a chain of credential
providers.
+ *
+ * <p>This class implements both AWS SDK V1 {@link AWSCredentialsProvider}
(for Presto) and AWS SDK
+ * V2 {@link AwsCredentialsProvider} (for Hadoop 3.4.0+) interfaces to support
both filesystems.
Review Comment:
Not really sure what is the overall plan here. Supporting 2 pieces of AWS
SDK versions sounds to me an instant nightmare. If we want to migrate to v2
it's fine but then we should do it. Anybody can enlighten me since I'm not sure
get things right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
