ctrlaltdilj commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3284745096
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/token/DynamicTemporaryAWSCredentialsProvider.java:
##########
@@ -37,9 +38,13 @@
* reference this class name from configuration property
fs.s3a.aws.credentials.provider. Therefore,
* changing the class name would be a backward-incompatible change. This
credential provider must
* not fail in creation because that will break a chain of credential
providers.
+ *
+ * <p>This class implements both AWS SDK V1 {@link AWSCredentialsProvider}
(for Presto) and AWS SDK
+ * V2 {@link AwsCredentialsProvider} (for Hadoop 3.4.0+) interfaces to support
both filesystems.
Review Comment:
btw if we want to approach this differently, I am open to ideas and happy to
contribute, my initial thought with this approach is being able to support both
AWS SDK, and then removing AWS SDK v1 after the presto upgrade is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
