Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3128#discussion_r97343787
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -70,16 +93,26 @@ public MetricSerializationResult(byte[] data, int
numCounters, int numGauges, in
//-------------------------------------------------------------------------
// Serialization
//-------------------------------------------------------------------------
+
public static class MetricDumpSerializer {
+
private DataOutputSerializer buffer = new
DataOutputSerializer(1024 * 32);
/**
* Serializes the given metrics and returns the resulting byte
array.
+ *
+ * Should a {@link Metric} accessed in this method throw an
exception it will be omitted from the returned
--- End diff --
Very nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
