Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3128#discussion_r97316717
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -50,12 +51,27 @@
private MetricDumpSerialization() {
}
+ public static class MetricSerializationResult {
+ public final byte[] data;
+ public final int numCounters;
+ public final int numGauges;
+ public final int numMeters;
+ public final int numHistograms;
+
+ public MetricSerializationResult(byte[] data, int numCounters,
int numGauges, int numMeters, int numHistograms) {
--- End diff --
Let's decrease the visibility of the constructor as much as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
