featzhang commented on code in PR #124:
URL:
https://github.com/apache/flink-connector-pulsar/pull/124#discussion_r3294214764
##########
flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/reader/deserializer/PulsarDeserializationSchemaTest.java:
##########
@@ -373,6 +399,22 @@ private <T> Message<byte[]> getMessage(
return MessageImpl.create(metadata, payload, Schema.BYTES, "");
}
+ /** Collector that records every {@link #collect} invocation, including
nulls. */
+ private static class CountingCollector<T> implements Collector<T> {
Review Comment:
Nit: `org.apache.flink.api.common.functions.util.ListCollector` would do the
same job (collect into a `List<T>`) without introducing a new test helper. Not
blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
