arvindKandpal-ksolves commented on PR #124: URL: https://github.com/apache/flink-connector-pulsar/pull/124#issuecomment-4532275389
@featzhang Thanks for the detailed review! I have addressed all your feedback in the latest commit. I added the null checks and DEBUG logging (with message IDs) across all four wrapper classes (PulsarDeserializationSchemaWrapper, PulsarSchemaWrapper, PulsarTypeInformationWrapper, and GenericRecordDeserializationSchema). I also replaced the custom test collector with Flink's native ListCollector and updated the tests to cover the new behavior. Please let me know if it looks good to go! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
