gustavodemorais commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3304570806


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/ToChangelogFunction.java:
##########
@@ -65,11 +70,16 @@ public class ToChangelogFunction extends 
BuiltInProcessTableFunction<RowData> {
 
     private final Map<RowKind, String> rawOpMap;
     private final int[] outputIndices;
+    private final RowType inputRowType;
+    private final boolean producesFullDelete;
+    private final boolean[] preserveOnDelete;

Review Comment:
   Something like this probably makes more sense 
   
   ```suggestion
       private final boolean[] upsertKeyIndex;
   ```
   Or upsertKeysAtIndex? or let me know if you have a better idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to