Savonitar opened a new pull request, #1123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1123

   ## What is the purpose of the change
   
   The flink-kubernetes-operator repository carries three identical local 
copies of 
https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/AggregatedMetric.java
 
   
   It shadows the upstream class at the same fully-qualified name so call sites 
resolved to the local copy when compiling against pre 1.20 Flink.
   
   
   ## Brief change log
   
   - Delete 
`flink-autoscaler/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/AggregatedMetric.java`
 
   - Delete 
`flink-kubernetes-operator/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/AggregatedMetric.java`
 
   - Delete 
`flink-autoscaler-standalone/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/AggregatedMetric.java`
   
   ## Verifying this change
   <!--
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   -->
   This change is already covered by existing tests: 
`RestApiMetricsCollectorTest`, `ScalingMetricCollectorTest`, 
`ScalingMetricsTest`, and `TestingFlinkService`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
(no)
     - Core observer or reconciler logic that is regularly executed: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to