Savonitar commented on PR #1123: URL: https://github.com/apache/flink-kubernetes-operator/pull/1123#issuecomment-4562268302
@Dennis-Mircea good catch, you are right. However it's worth to mention that two of the three local copies being deleted already have the `mim=` typo themselves, e.g. [`flink-kubernetes-operator/.../AggregatedMetric.java#L130`](https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/AggregatedMetric.java#L130) So removing those two wouldn't regress anything, the regression only matters for the autoscaler module. As for the actual usage: I originally raised this PR because I couldn't find any explicit `toString()` call. But there is one implicit call in `ScalingMetricCollector.java` https://github.com/apache/flink-kubernetes-operator/blob/main/flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java#L339 Thanks, agree we can postpone this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
