gustavodemorais commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3311467478
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ToChangelogTestPrograms.java:
##########
@@ -187,7 +187,8 @@ public class ToChangelogTestPrograms {
public static final TableTestProgram UPSERT_PARTITION_BY =
TableTestProgram.of(
"to-changelog-upsert-partition-by",
- "PARTITION BY upsert key + mapping without UB
skips ChangelogNormalize")
+ "PARTITION BY upsert key + mapping without UB
skips ChangelogNormalize; "
+ + "default produces_full_deletes=false
nulls non-key columns on DELETE")
Review Comment:
"default produces_full_deletes=false" is wrong and not relevant to the test.
I think you can just delete this additional description you added
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PartitionedTable.java:
##########
@@ -204,9 +204,17 @@ public interface PartitionedTable {
* descriptor("deleted").asArgument("op"),
* map("INSERT, UPDATE_AFTER", "false", "DELETE",
"true").asArgument("op_mapping")
* );
+ *
+ * // Opt out of full-delete semantics. When `true` (default), DELETE rows
carry the full
+ * // pre-image. When `false`, only the identifying key columns are
preserved and the rest
+ * // are nulled. See [Delete handling](#delete-handling) for more details.
Review Comment:
I added the suggestion manually so didn't paste the proper link. Can you
make sure you add the proper link and formatting for both partitionedtable and
table?
```suggestion
* // are nulled. See [Full or partial deletes](<correct link>) for more
details.
```
##########
docs/content/docs/sql/reference/queries/changelog.md:
##########
@@ -434,6 +520,15 @@ Table result = myTable.toChangelog(
map("INSERT, UPDATE_AFTER", "false", "DELETE",
"true").asArgument("op_mapping")
);
+// Require fully-populated DELETE rows from the input (inserts a
ChangelogNormalize for
+// upsert sources). When false (default), no full-delete requirement is
enforced; in row
Review Comment:
"When false (default)" still out of date. Can you double check we changed
the default and adjusted docs everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
