raminqaf commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3312031991


##########
docs/content/docs/sql/reference/queries/changelog.md:
##########
@@ -434,6 +520,15 @@ Table result = myTable.toChangelog(
     map("INSERT, UPDATE_AFTER", "false", "DELETE", 
"true").asArgument("op_mapping")
 );
 
+// Require fully-populated DELETE rows from the input (inserts a 
ChangelogNormalize for
+// upsert sources). When false (default), no full-delete requirement is 
enforced; in row

Review Comment:
   Updated all the docs and everything should be aligned now!



##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PartitionedTable.java:
##########
@@ -204,9 +204,17 @@ public interface PartitionedTable {
      *         descriptor("deleted").asArgument("op"),
      *         map("INSERT, UPDATE_AFTER", "false", "DELETE", 
"true").asArgument("op_mapping")
      *     );
+     *
+     * // Opt out of full-delete semantics. When `true` (default), DELETE rows 
carry the full
+     * // pre-image. When `false`, only the identifying key columns are 
preserved and the rest
+     * // are nulled. See [Delete handling](#delete-handling) for more details.

Review Comment:
   Fixed! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to