snuyanzin commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3312576988
##########
flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java:
##########
@@ -575,4 +584,57 @@ void ensureSupportedFlinkDate(Object flinkDate) {
LocalDate.class.getName(),
flinkDate.getClass().getName());
}
+
+ @Override
+ public List<String> getStructFieldNames(StructTypeInfo structTypeInfo) {
+ return new ArrayList<>(structTypeInfo.getAllStructFieldNames());
+ }
+
+ @Override
+ public List<TypeInfo> getStructFieldTypeInfos(StructTypeInfo
structTypeInfo) {
+ return new ArrayList<>(structTypeInfo.getAllStructFieldTypeInfos());
+ }
+
+ @Override
+ public void initializeSerDe(
+ Deserializer deserializer,
+ Configuration conf,
+ Properties tableProperties,
+ Properties partitionProperties)
+ throws SerDeException {
+ SerDeUtils.initializeSerDe(deserializer, conf, tableProperties,
partitionProperties);
+ }
+
+ @Override
+ public Object createPrincipalDesc(String principalName, PrincipalType
principalType) {
+ return new org.apache.hadoop.hive.ql.plan.PrincipalDesc(principalName,
principalType);
Review Comment:
was it generated with claude?
why do we need absolute path here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
