snuyanzin commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3312610185
##########
flink-connector-hive/pom.xml:
##########
@@ -1425,5 +1427,78 @@ under the License.
<jdk>[11,)</jdk>
</activation>
</profile>
+ <profile>
+ <id>hive4</id>
+ <properties>
+ <hive.version>4.0.0</hive.version>
+ <hive.hadoop.version>3.3.6</hive.hadoop.version>
+
<hive4.datanucleus-api-jdo.version>5.2.8</hive4.datanucleus-api-jdo.version>
+
<hive4.datanucleus-rdbms.version>5.2.10</hive4.datanucleus-rdbms.version>
+ </properties>
+ <dependencies>
+ <!--
+ hive-exec 4.x bundles protobuf 3.x
(unshaded). Override the transitive
+ protobuf 2.5.0 from Hadoop so the
bundled ORC/protobuf code works on
+ the flat test classpath. The production
fat jar handles this via shading.
+ -->
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.3.0</version>
+ <scope>test</scope>
+ </dependency>
+ <!-- Hive 4 requires compatible DataNucleus for
the embedded metastore.
+ 4.0.x uses 5.x, 4.1+ uses 6.x.
Override via -Dhive4.datanucleus-api-jdo.version=6.0.3 etc. -->
Review Comment:
why do we need this comment?
isn't it clear from property declaration?
who will remember to update/check that this comment is updated next time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
