Dennis-Mircea commented on code in PR #1121:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1121#discussion_r3315906212
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkResourceContextFactory.java:
##########
@@ -98,39 +102,40 @@ public FlinkStateSnapshotContext
getFlinkStateSnapshotContext(
configManager);
}
+ public BlueGreenContext getBlueGreenContext(
+ FlinkBlueGreenDeployment bgDeployment,
+ FlinkBlueGreenDeploymentStatus deploymentStatus,
+ Context<FlinkBlueGreenDeployment> josdkContext,
+ FlinkBlueGreenDeployments deployments) {
+ return new BlueGreenContext(
+ bgDeployment, deploymentStatus, josdkContext, deployments,
this);
+ }
+
+ @SuppressWarnings("unchecked")
public <CR extends AbstractFlinkResource<?, ?>> FlinkResourceContext<CR>
getResourceContext(
- CR resource, Context josdkContext) {
+ CR resource, Context<CR> josdkContext) {
Review Comment:
Good catch, you are right, that was a real break, I don't know how I missed
that. I changed the type from CR to ?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
