Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97524568
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -245,14 +235,15 @@ public int getKeyGroupPrefixBytes() {
// hold the db lock while operation on the db to guard us
against async db disposal
synchronized (asyncSnapshotLock) {
- if (kvStateInformation.isEmpty()) {
- LOG.info("Asynchronous RocksDB snapshot
performed on empty keyed state at " + timestamp +
- " . Returning null.");
+ if (db != null) {
- return new DoneFuture<>(null);
- }
+ if (kvStateInformation.isEmpty()) {
+ LOG.info("Asynchronous RocksDB snapshot
performed on empty keyed state at " + timestamp +
--- End diff --
Wondering whether we should log this on debug. As a user, I don't know how
useful this is for me when I see this message in my logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
