Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97554901
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend createOperatorStateBackend(
String operatorIdentifier) throws Exception {
return new
DefaultOperatorStateBackend(env.getUserClassLoader());
}
+
+ @Override
+ public void close() throws Exception {
+
+ }
--- End diff --
The reason for not renaming it is because it's used in the (admittedly
`@PublicEvolcing`) method `StreamExecutionEnvironment.setStateBackend()`. If we
didn't have that I would also prefer renaming this to something like
`StateBackendFactory`.
The fact that it is in fact a factory (that should be stateless) makes me a
bit uneasy about adding a `close()` method to the `AbstractStateBackend`. Why
is it needed, in fact?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
