raminqaf commented on code in PR #28277:
URL: https://github.com/apache/flink/pull/28277#discussion_r3324173061
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/MergeTableAsUtil.java:
##########
@@ -156,7 +156,7 @@ public PlannerQueryOperation maybeRewriteQuery(
() -> "Unsupported node type " +
origQueryNode.getKind());
return (PlannerQueryOperation)
- SqlNodeToOperationConversion.convert(flinkPlanner,
catalogManager, newSelect)
+ SqlNodeToOperationConversion.convert(flinkPlanner,
catalogManager, newSelect, null)
Review Comment:
The conversion path here never calls `toRawString` here. So it is safe. Even
if it gets fired the `newSelect` is synthesized by `rewriteCall`, so the
slicing would produce wrong values here. So the correct behavior would be to
pass null to get an `optional#empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
