snuyanzin commented on code in PR #28277:
URL: https://github.com/apache/flink/pull/28277#discussion_r3334534806
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/AbstractCreateMaterializedTableConverter.java:
##########
@@ -141,10 +141,20 @@ protected final RefreshMode
getDerivedRefreshMode(LogicalRefreshMode logicalRefr
return
MaterializedTableUtils.fromLogicalRefreshModeToRefreshMode(logicalRefreshMode);
}
+ /**
+ * Returns the {@code AS} query exactly as the user wrote it.
Review Comment:
is this statement true?
what if there is a query like
```sql
create view myview
/* this is my view start comment */
select 1;
/* this is my view end comment */
```
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/AbstractCreateMaterializedTableConverter.java:
##########
@@ -141,10 +141,20 @@ protected final RefreshMode
getDerivedRefreshMode(LogicalRefreshMode logicalRefr
return
MaterializedTableUtils.fromLogicalRefreshModeToRefreshMode(logicalRefreshMode);
}
+ /**
+ * Returns the {@code AS} query exactly as the user wrote it.
Review Comment:
is this statement true?
what if there is a query like
```sql
create view myview as
/* this is my view start comment */
select 1;
/* this is my view end comment */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
