snuyanzin commented on code in PR #28278:
URL: https://github.com/apache/flink/pull/28278#discussion_r3325221137
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-process-table-function_1/from-changelog-retract-partition-by-restore/plan/from-changelog-retract-partition-by-restore.json:
##########
@@ -0,0 +1,153 @@
+{
+ "flinkVersion" : "2.4",
+ "nodes" : [ {
+ "id" : 4,
+ "type" : "stream-exec-table-source-scan_2",
+ "scanTableSource" : {
+ "table" : {
+ "identifier" : "`default_catalog`.`default_database`.`cdc_stream`",
+ "resolvedTable" : {
+ "schema" : {
+ "columns" : [ {
+ "name" : "name",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "id",
+ "dataType" : "INT"
+ }, {
+ "name" : "op",
+ "dataType" : "VARCHAR(2147483647)"
+ } ]
+ }
+ }
+ }
+ },
+ "outputType" : "ROW<`name` VARCHAR(2147483647), `id` INT, `op`
VARCHAR(2147483647)>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, cdc_stream]], fields=[name, id, op])"
+ }, {
+ "id" : 5,
+ "type" : "stream-exec-exchange_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "HASH",
+ "keys" : [ 1 ]
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`name` VARCHAR(2147483647), `id` INT, `op`
VARCHAR(2147483647)>",
+ "description" : "Exchange(distribution=[hash[id]])"
+ }, {
+ "id" : 6,
+ "type" : "stream-exec-process-table-function_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "UNKNOWN"
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`id` INT, `name` VARCHAR(2147483647)>",
+ "description" : "ProcessTableFunction(invocation=[FROM_CHANGELOG(TABLE(#0)
PARTITION BY($1), DEFAULT(), DEFAULT(), DEFAULT(), DEFAULT(), DEFAULT())],
uid=[FROM_CHANGELOG], select=[id,name], rowType=[RecordType(INTEGER id,
VARCHAR(2147483647) name)])",
+ "uid" : "FROM_CHANGELOG",
+ "functionCall" : {
+ "kind" : "CALL",
+ "internalName" : "$FROM_CHANGELOG$1",
+ "operands" : [ {
+ "kind" : "TABLE_ARG_CALL",
+ "inputIndex" : 0,
+ "partitionKeys" : [ 1 ],
+ "orderKeys" : [ ],
+ "orderDirections" : [ ],
Review Comment:
I guess we don't need to serialize it if they are empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
