gustavodemorais commented on code in PR #28278:
URL: https://github.com/apache/flink/pull/28278#discussion_r3325492693
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/ToChangelogOutputTypeStrategyTest.java:
##########
@@ -105,6 +106,55 @@ ARG_TABLE, new
TableSemanticsMock(TABLE_TYPE_NOT_NULL_SCORE))
DataTypes.FIELD("op",
DataTypes.STRING()),
DataTypes.FIELD("name",
DataTypes.STRING()),
DataTypes.FIELD("score",
DataTypes.BIGINT()))
+ .notNull()),
+ // Set semantics: PARTITION BY strips the partition column
from the projected
+ // output (the framework prepends it back outside the
function), so the strategy
+ // returns only [op, non_partition_input_cols]. With full
deletes the row is
+ // passed through unchanged so non-partition NOT NULL columns
stay non-nullable.
Review Comment:
I actually find the comment helpful to explain the test for people that
aren't so familiar with all the concepts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
