ctrlaltdilj commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3329028832


##########
flink-filesystems/flink-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE:
##########
@@ -9,39 +9,63 @@ This project bundles the following dependencies under the 
Apache Software Licens
 - com.fasterxml.jackson.core:jackson-annotations:2.21
 - com.fasterxml.jackson.core:jackson-core:2.21.3
 - com.fasterxml.jackson.core:jackson-databind:2.21.3
-- com.fasterxml.woodstox:woodstox-core:5.3.0
-- com.google.guava:failureaccess:1.0
-- com.google.guava:guava:27.0-jre
+- com.fasterxml.woodstox:woodstox-core:5.4.0
+- com.github.pjfanning:jersey-json:1.22.0
+- com.google.guava:failureaccess:1.0.1
+- com.google.guava:guava:32.0.1-jre
 - com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-- com.google.j2objc:j2objc-annotations:1.1
-- commons-beanutils:commons-beanutils:1.9.4
-- commons-collections:commons-collections:3.2.2
+- com.google.j2objc:j2objc-annotations:2.8
+- com.sun.xml.bind:jaxb-impl:2.2.3-1
 - commons-io:commons-io:2.15.1
 - commons-logging:commons-logging:1.1.3
+- io.dropwizard.metrics:metrics-core:3.2.4
+- io.netty:netty-buffer:4.2.13.Final
+- io.netty:netty-codec-base:4.2.13.Final
+- io.netty:netty-common:4.2.13.Final
+- io.netty:netty-handler:4.2.13.Final
+- io.netty:netty-resolver:4.2.13.Final
+- io.netty:netty-transport:4.2.13.Final
+- io.netty:netty-transport-classes-epoll:4.2.13.Final
+- io.netty:netty-transport-native-epoll:4.2.13.Final
+- io.netty:netty-transport-native-unix-common:4.2.13.Final

Review Comment:
   Done



##########
flink-filesystems/flink-s3-fs-hadoop/pom.xml:
##########
@@ -84,12 +84,35 @@ under the License.
                        <scope>test</scope>
                </dependency>
 
-               <!-- S3 base -->
+               <!-- S3 base - exclude AWS SDK v1 -->
                <dependency>
                        <groupId>org.apache.flink</groupId>
                        <artifactId>flink-s3-fs-base</artifactId>
                        <version>${project.version}</version>
                        <optional>${flink.markBundledAsOptional}</optional>
+                       <exclusions>
+                               <!-- Exclude all AWS SDK v1 dependencies - we 
use SDK v2 -->
+                               <exclusion>

Review Comment:
   Updated comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to