spoorthibasu commented on code in PR #4360:
URL: https://github.com/apache/flink-cdc/pull/4360#discussion_r3330820919
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/v2/IcebergCommitter.java:
##########
@@ -62,6 +63,12 @@ public class IcebergCommitter implements
Committer<WriteResultWrapper> {
public static final String TABLE_GROUP_KEY = "table";
+ /** Snapshot summary key for the batch index; used to resume partial
commits on retry. */
+ static final String FLINK_BATCH_INDEX = "flink.batch-index";
+
+ /** Snapshot summary key for the checkpoint ID on intermediate batch
commits. */
+ static final String FLINK_CHECKPOINT_ID_PROP = "flink.checkpoint-id";
Review Comment:
Agreed, moved both keys under the `flink-cdc.` prefix
(flink-cdc.batch-index, flink-cdc.checkpoint-id) so they stay out of the
connector's `flink.` namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
