spoorthibasu commented on PR #4360: URL: https://github.com/apache/flink-cdc/pull/4360#issuecomment-4589256954
Thanks so much for the review and approval @lvyanquan, and for assigning the ticket. On the E2E edge cases: happy to add a few more interleaved UPDATE/DELETE plus schema-change scenarios. I can push them to this PR if you'd like, or keep this one as-is and do them as a follow-up, whichever you prefer. Heads up on the two remaining red checks, both unrelated to this change (it only touches the Iceberg sink), and the same two suites pass on the 2.x runs: - **Source Unit Tests / test (11, generic, oracle, sqlserver)**: Oracle passes; the SQL Server tests can't pull their Docker image (`mcr.microsoft.com/mssql/server:2019-latest` returns `Status 404, "The request is blocked"`), so `SqlServerParallelSourceExampleTest`, `SqlserverSourceReaderTest`, and `SqlServerScanFetchTaskTest` error out before running. - **Source Unit Tests / test (11, generic, postgres-source, oceanbase-source, tidb, vitess)**: the flaky `OceanBaseFailoverITCase.testTaskManagerFailoverSingleParallelism[3]` (a data-comparison assertion in a failover test). All the Iceberg pipeline unit and E2E suites pass. Could you please re-run these two when you get a chance? Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
