spuru9 commented on code in PR #28261:
URL: https://github.com/apache/flink/pull/28261#discussion_r3333114709
##########
flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStResourceContainerTest.java:
##########
@@ -298,20 +296,22 @@ public ColumnFamilyOptions createColumnOptions(
ColumnFamilyOptions columnOptions = container.getColumnOptions();
BlockBasedTableConfig actual =
(BlockBasedTableConfig) columnOptions.tableFormatConfig();
- assertThat(actual.indexType(), is(IndexType.kTwoLevelIndexSearch));
- assertThat(actual.partitionFilters(), is(true));
- assertThat(actual.pinTopLevelIndexAndFilter(), is(true));
- assertFalse(actual.filterPolicy() == blockBasedFilter);
+
assertThat(actual.indexType()).isEqualTo(IndexType.kTwoLevelIndexSearch);
+ assertThat(actual.partitionFilters()).isTrue();
+ assertThat(actual.pinTopLevelIndexAndFilter()).isTrue();
+ assertThat(actual.filterPolicy()).isNotSameAs(blockBasedFilter);
}
- assertFalse("Block based filter is left unclosed.",
blockBasedFilter.isOwningHandle());
+ assertThat(blockBasedFilter.isOwningHandle())
+ .as("Block based filter is left unclosed.")
+ .isFalse();
}
@Test
- public void testDirectoryResources() throws Exception {
- Path localJobPath = new Path(TMP_FOLDER.newFolder().getPath());
+ void testDirectoryResources() throws Exception {
+ Path localJobPath = new
Path(TempDirUtils.newFolder(tmpFolder).getPath());
Review Comment:
Multiple distinct temp dirs are needed here, so
TempDirUtils.newFolder(tmpFolder) is simpler than injecting several `@TempDir`
params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
