spuru9 commented on code in PR #28261:
URL: https://github.com/apache/flink/pull/28261#discussion_r3333157000
##########
flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStIncrementalCheckpointRescalingTest.java:
##########
@@ -149,7 +151,7 @@ public void testScalingUp() throws Exception {
harness.setStateBackend(getStateBackend());
harness.setCheckpointStorage(
new FileSystemCheckpointStorage(
- "file://" +
rootFolder.newFolder().getAbsolutePath()));
+ "file://" +
TempDirUtils.newFolder(rootFolder).getAbsolutePath()));
Review Comment:
Have used `@TempDir` now in the places only one directory is needed. But the
Utils in the case of multiple, I believe its a cleaner approach to not use
multiple `@TempDir`, also TempDirUtils is created for the same purpose.
I was using TempDirUtils.newFolder(rootFolder).getAbsolutePath())) as it is
being recommended in
https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit?tab=t.0#heading=h.we2n5aifcjfq
> We provide a util class TempDirUtils for implementing common functions in
TemporaryFolder, like newFolder() and newFile().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
