snuyanzin opened a new pull request, #28284:
URL: https://github.com/apache/flink/pull/28284

   ## What is the purpose of the change
   This is a preliminary change before bumping Calcite to 1.39.0
   
   The main reason here is that this class is relatively often a problem while 
Calcite upgrade if something is changed in interfaces (new default methods for 
instance)
   maven just fails as
   ```
    [ERROR] error: Error while emitting FlinkTypeFactory.scala
     [ERROR] assertion failed:
     [ERROR]   cannot invokespecial 
org/apache/calcite/rel/type/RelDataTypeFactory.leastRestrictive, the interface 
is not a direct parent.
     [ERROR]      while compiling: 
.../flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
     [ERROR]         during phase: jvm
     [ERROR]      library version: version 2.12.20
     [ERROR]     compiler version: version 2.12.20
     ...
     [INFO]   last tree to typer: TypeTree(class FlinkHintStrategies)
     [INFO]             tree tpe: 
org.apache.flink.table.planner.hint.FlinkHintStrategies
     ...
     [WARNING] 42 warnings found
     [ERROR] one error found
   ```
   
   ## Brief change log
   
   FlinkTypeFactory to java
   
   
   ## Verifying this change
   
   existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no )
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` followed by the name of the tool, and 
uncomment the
   "Generated-by" line. See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name and Version]
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to