snuyanzin commented on code in PR #28284:
URL: https://github.com/apache/flink/pull/28284#discussion_r3334944816
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/catalog/CatalogSchemaModel.java:
##########
@@ -101,12 +100,13 @@ public RexNode toRex(SqlRexContext rexContext) {
private static RelDataType schemaToRelDataType(
FlinkTypeFactory typeFactory, ResolvedSchema schema) {
- final List<String> fieldNames = schema.getColumnNames();
- final List<LogicalType> fieldTypes =
+ final String[] fieldNames = schema.getColumnNames().toArray(new
String[0]);
+ final LogicalType[] fieldTypes =
schema.getColumnDataTypes().stream()
.map(DataType::getLogicalType)
.map(PlannerTypeUtils::removeLegacyTypes)
- .collect(Collectors.toList());
+ .collect(Collectors.toList())
+ .toArray(new LogicalType[0]);
Review Comment:
made using lists here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
