Efrat19 opened a new pull request, #28285:
URL: https://github.com/apache/flink/pull/28285
## What is the purpose of the change
Allow s5cmd to be adjusted to file size and concurrency instead of the
static 50MiB
## Brief change log
- Introduced part-size to s5cmd cp command, taking fileSize/concurrency if
`s3.s5cmd.adjust-part-size` is enabled and 50MiB otherwise (50MiB being s5cmd
default)
## Verifying this change
This change added tests and can be verified as follows:
- Added a parameterized test ensuring the part-size is used with s5cmd,
adjusted correctly to different file sizes, aws min and max, and uses the
default part-size when the flag is disabled.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes - Recovery from s3
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
---
##### Was generative AI tooling used to co-author this PR?
Claude Opus 4.7 was used to generate the tests in
`flink-filesystems/flink-s3-fs-base/src/test/java/org/apache/flink/fs/s3/common/FlinkS3FileSystemTest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
