pnowojski commented on code in PR #28285:
URL: https://github.com/apache/flink/pull/28285#discussion_r3339720479
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java:
##########
@@ -90,6 +90,19 @@ public abstract class AbstractS3FileSystemFactory implements
FileSystemFactory {
.defaultValue(100)
.withDescription("Maximum number of files to download per
one call to s5cmd");
+ public static final ConfigOption<Boolean> S5CMD_ADJUST_PART_SIZE =
+ ConfigOptions.key("s3.s5cmd.adjust-part-size")
+ .booleanType()
+ .defaultValue(false)
Review Comment:
optional: I think it would be a bit better to make it enabled default and
add a release note how to restore the old behaviour if it causes problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
