fresh-borzoni commented on code in PR #28090:
URL: https://github.com/apache/flink/pull/28090#discussion_r3373764502
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1303,27 +1319,35 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
createNewNode(process, Some(children), providedDeleteTrait)
case join: StreamPhysicalJoin =>
Review Comment:
Good call. Added guards for MultiJoin, TemporalJoin, LookupJoin and
Correlate. Interval/Window joins can't hit this, their inputs are append-only,
so there's no UB to drop.
For ChangelogNormalize I didn't add a guard, but instead it now falls back
to accepting BEFORE_AND_AFTER from its child when UA-only isn't possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
